Skip to content

Make dirmult a required dependency for clusterSize - #258

Open
JorAlEs wants to merge 1 commit into
kgoldfeld:mainfrom
AlgoriaBiometrics:fix-clustersize-dependency
Open

JorAlEs wants to merge 1 commit into
kgoldfeld:mainfrom
AlgoriaBiometrics:fix-clustersize-dependency

Conversation

@JorAlEs

@JorAlEs JorAlEs commented Oct 27, 2026

Copy link
Copy Markdown

Move dirmult from Suggests to Imports so clusterSize works after a standard
installation. Remove the redundant dependency check and its misleading
Poisson error message.

Add tests for genData() and addColumns() with zero and positive dispersion,
covering integer nonnegative sizes, totals, balance and identifier preservation.

Validation on Windows:

  • Installation with mandatory dependencies passed.
  • Full R 4.5.2 build/check, including vignettes and manual: clean.
  • R 4.6.0 suite: no failures, with dependency build-version warnings.

Linux, macOS, R-devel and remote CI have not been tested.

Fixes #257

Algoria

@JorAlEs

JorAlEs commented Nov 9, 2026

Copy link
Copy Markdown
Author

Hi @kgoldfeld, a quick follow-up on this fix for the clusterSize() dependency. The CI workflows are awaiting approval. Could you enable them when you have a chance? Happy to address any review feedback.

Thanks!
Algoria

@kgoldfeld

Copy link
Copy Markdown
Owner

Yes - I need to get to this - been a bit busy. I'll try for later this week.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move dirmult from Suggests to Imports and clean up clusterSize dependency handling

2 participants