Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Backup-only cycling adjusts runtime without correcting airflow and supply temperature, causing incorrect duct losses and infiltration, while timer-controlled ventilation still uses raw runtime and omits additional fan energy and duct losses.
2 open issues
What changed in this PR
Extends #2303’s fan-power workaround to duct-loss modeling, using EMS to account for heat-pump backup-only cycling affected by EnergyPlus #11903.
Changes:
- Exposes the supplemental-only cycling fraction through an EMS global variable.
- Uses that fraction to adjust fan runtime in duct calculations.
- Refreshes simulation baselines and measure metadata.
| File | Description |
|---|---|
workflow/tests/base_results/results_simulations_misc.csv |
Updates miscellaneous simulation baselines. |
workflow/tests/base_results/results_simulations_loads.csv |
Updates expected heating and duct loads. |
workflow/tests/base_results/results_simulations_energy.csv |
Updates expected energy use. |
workflow/tests/base_results/results_simulations_bills.csv |
Updates expected utility bills. |
HPXMLtoOpenStudio/resources/hvac.rb |
Publishes the backup-only cycling fraction for reuse. |
HPXMLtoOpenStudio/resources/airflow.rb |
Tracks supply fans and adjusts duct-model fan runtime. |
HPXMLtoOpenStudio/measure.xml |
Refreshes version metadata and resource checksums. |
Review effort: Max
…LabRockies/OpenStudio-HPXML into supp_coil_cycling_workaround_duct_losses # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
3 of 7 tasks
…HPXML into supp_coil_cycling_workaround_duct_losses # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
shorowit
force-pushed
the
supp_coil_cycling_workaround_duct_losses
branch
from
November 20, 2026 05:20
b576ef5 to
e1ba987
Compare
…HPXML into supp_coil_cycling_workaround_duct_losses # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Backup-only corrections use an incorrect return-state reference and a capacity fraction that ignores supply-temperature limits, miscalculating delivered heat and duct/leakage losses.
4 open issues
2 resolved since last review
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request Description
Adds on top of #2303. Updates the duct losses program to factor in supplemental coil cycling. Workaround for NatLabRockies/EnergyPlus#11903 where the supplemental coil is always assigned a runtime fraction of 1 even when it's really cycling.
Example below of reduced duct losses during backup heating only operation for a dual fuel HP. Top graph is HP heating (before: blue, after: red). Bottom graph is backup heating (before: orange, after: grey). There is a little weirdness at the edges because of the EMS timestep lag, but otherwise looks good.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run