Skip to content

Fix duct losses during HP backup only events using EMS - #2304

Draft
shorowit wants to merge 10 commits into
masterfrom
supp_coil_cycling_workaround_duct_losses
Draft

shorowit wants to merge 10 commits into
masterfrom
supp_coil_cycling_workaround_duct_losses

Conversation

@shorowit

@shorowit shorowit commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Description

Adds on top of #2303. Updates the duct losses program to factor in supplemental coil cycling. Workaround for NatLabRockies/EnergyPlus#11903 where the supplemental coil is always assigned a runtime fraction of 1 even when it's really cycling.

Example below of reduced duct losses during backup heating only operation for a dual fuel HP. Top graph is HP heating (before: blue, after: red). Bottom graph is backup heating (before: orange, after: grey). There is a little weirdness at the edges because of the EMS timestep lag, but otherwise looks good.

image

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Backup-only cycling adjusts runtime without correcting airflow and supply temperature, causing incorrect duct losses and infiltration, while timer-controlled ventilation still uses raw runtime and omits additional fan energy and duct losses.

2 open issues
What changed in this PR

Extends #2303’s fan-power workaround to duct-loss modeling, using EMS to account for heat-pump backup-only cycling affected by EnergyPlus #11903.

Changes:

  • Exposes the supplemental-only cycling fraction through an EMS global variable.
  • Uses that fraction to adjust fan runtime in duct calculations.
  • Refreshes simulation baselines and measure metadata.
File Description
workflow/​tests/​base_results/​results_simulations_misc.csv Updates miscellaneous simulation baselines.
workflow/​tests/​base_results/​results_simulations_loads.csv Updates expected heating and duct loads.
workflow/​tests/​base_results/​results_simulations_energy.csv Updates expected energy use.
workflow/​tests/​base_results/​results_simulations_bills.csv Updates expected utility bills.
HPXMLtoOpenStudio/​resources/​hvac.rb Publishes the backup-only cycling fraction for reuse.
HPXMLtoOpenStudio/​resources/​airflow.rb Tracks supply fans and adjusts duct-model fan runtime.
HPXMLtoOpenStudio/​measure.xml Refreshes version metadata and resource checksums.

Review effort: Max

Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
…LabRockies/OpenStudio-HPXML into supp_coil_cycling_workaround_duct_losses

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_bills.csv
#	workflow/tests/base_results/results_simulations_loads.csv
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML Nov 17, 2026
@shorowit shorowit added this to the 1.13.0 milestone Nov 17, 2026
Base automatically changed from supp_coil_cycling_workaround to master November 19, 2026 16:46
shorowit and others added 3 commits November 19, 2026 16:08
…HPXML into supp_coil_cycling_workaround_duct_losses

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_bills.csv
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit
shorowit force-pushed the supp_coil_cycling_workaround_duct_losses branch from b576ef5 to e1ba987 Compare November 20, 2026 05:20
…HPXML into supp_coil_cycling_workaround_duct_losses

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
#	workflow/tests/base_results/results_simulations_misc.csv

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Backup-only corrections use an incorrect return-state reference and a capacity fraction that ignores supply-temperature limits, miscalculating delivered heat and duct/leakage losses.

4 open issues
2 resolved since last review

Review effort: Max

Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants