Skip to content

Fix fan power during HP backup only events using EMS - #2303

Merged
shorowit merged 17 commits into
masterfrom
supp_coil_cycling_workaround
Nov 19, 2026
Merged

shorowit merged 17 commits into
masterfrom
supp_coil_cycling_workaround

Conversation

@shorowit

@shorowit shorowit commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Description

Uses EMS to actuate the supply fan's power for heat pumps when only the backup is running (i.e., when the HP is locked out). Workaround for NatLabRockies/EnergyPlus#11903 where the supplemental coil is always assigned a runtime fraction of 1 even when it's really cycling.

Example of heating fan power before (blue) vs after (orange) for a dual-fuel heat pump:

image

Example of heating fan power before (blue) vs after (orange) for an all-electric heat pump:

image

In the above graph, Jan 7 has both HP and supplemental heating, so the fan power is correct, while Jan 1 and Jan 4 have only supplemental heating (HP is locked out due to the outdoor temperature), so the fan power gets adjusted.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved
Base automatically changed from vshp_fan_power_workaround to master November 13, 2026 01:51
shorowit and others added 4 commits November 12, 2026 19:00
…HPXML into supp_coil_cycling_workaround

# Conflicts:
#	workflow/tests/base_results/results_simulations_bills.csv
#	workflow/tests/base_results/results_simulations_energy.csv
#	workflow/tests/base_results/results_simulations_loads.csv
@shorowit
shorowit requested a max review from Copilot November 13, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

4 open issues
What changed in this PR

Updates HPXML-to-OpenStudio HVAC translation to correct heat pump supply fan power during backup-only (or supplementary-only) operation by using EMS override logic, with corresponding regression baseline updates.

Changes:

  • Extend supply fan creation to pass coil references into a fan-power EMS program.
  • Add EMS logic to scale/zero fan power when the supplemental coil is cycling (or absent) to work around an EnergyPlus runtime-fraction bug.
  • Update workflow regression baseline CSVs and measure metadata/checksums to reflect new simulation outputs.
File Description
HPXMLtoOpenStudio/​resources/​hvac.rb Implements EMS-based fan power override logic and updates method signatures/docs.
HPXMLtoOpenStudio/​measure.xml Updates measure version metadata and resource checksum after code changes.
workflow/​tests/​base_results/​results_simulations_misc.csv Updates expected misc simulation results impacted by fan power changes.
workflow/​tests/​base_results/​results_simulations_loads.csv Updates expected loads results impacted by fan power changes.
workflow/​tests/​base_results/​results_simulations_energy.csv Updates expected energy results impacted by fan power changes.
workflow/​tests/​base_results/​results_simulations_bills.csv Updates expected bill results impacted by fan power changes.

Review effort: Lite

Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Backup-only fan-power scaling leaves CFIS using a runtime of 1, omitting ventilation-only fan energy in air-handler mode and overstating ventilation credit under optimized control.

1 open issue
4 resolved since last review

Review effort: Max

Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Runtime accounting still mishandles all-coils-off lockouts and backup-only CFIS operation, leaving spurious fan power and overstating duct losses and heating demand.

2 open issues
1 resolved since last review

Review effort: Max

Comment thread HPXMLtoOpenStudio/resources/airflow.rb Resolved
Comment thread HPXMLtoOpenStudio/resources/hvac.rb Resolved
@shorowit
shorowit marked this pull request as ready for review November 17, 2026 00:12
@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML Nov 17, 2026
@shorowit shorowit added this to the 1.13.0 milestone Nov 17, 2026
@shorowit
shorowit requested a max review from Copilot November 19, 2026 16:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The backup-only fan-power override lacks targeted timestep-level regression tests, leaving incorrect part-load scaling and overrides persisting into compressor heating or cooling insufficiently guarded against.

1 open issue
2 resolved since last review

Review effort: Max

Comment on lines +2603 to +2604
fan_power_program.addLine('If (SuppOnlyCyclingRuntimeFraction >= 0) && (SuppOnlyCyclingRuntimeFraction < 1)')
fan_power_program.addLine(" Set #{fan_press_actuator.name} = SuppOnlyCyclingRuntimeFraction * #{fan.designPressureRise}")
@shorowit
shorowit merged commit 7315b5b into master Nov 19, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in OpenStudio-HPXML Nov 19, 2026
@shorowit
shorowit deleted the supp_coil_cycling_workaround branch November 19, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants