Repository navigation
Fix fan power during HP backup only events using EMS - #2303
Conversation
…HPXML into supp_coil_cycling_workaround # Conflicts: # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
htg_supp_coil.nominalCapacityis typically an OptionalDouble in OpenStudio. Interpolating it into… · New The YARD type annotations useXXXplaceholders (e.g., `CoilHeatingWaterToAirHeatPumpXXXEquationFit… · New These EMS conditionals compare floating-point sensors to0using exact equality (== 0). EMS… · New Correct typo “mdeol” to “model”. · New
What changed in this PR
Updates HPXML-to-OpenStudio HVAC translation to correct heat pump supply fan power during backup-only (or supplementary-only) operation by using EMS override logic, with corresponding regression baseline updates.
Changes:
- Extend supply fan creation to pass coil references into a fan-power EMS program.
- Add EMS logic to scale/zero fan power when the supplemental coil is cycling (or absent) to work around an EnergyPlus runtime-fraction bug.
- Update workflow regression baseline CSVs and measure metadata/checksums to reflect new simulation outputs.
| File | Description |
|---|---|
HPXMLtoOpenStudio/resources/hvac.rb |
Implements EMS-based fan power override logic and updates method signatures/docs. |
HPXMLtoOpenStudio/measure.xml |
Updates measure version metadata and resource checksum after code changes. |
workflow/tests/base_results/results_simulations_misc.csv |
Updates expected misc simulation results impacted by fan power changes. |
workflow/tests/base_results/results_simulations_loads.csv |
Updates expected loads results impacted by fan power changes. |
workflow/tests/base_results/results_simulations_energy.csv |
Updates expected energy results impacted by fan power changes. |
workflow/tests/base_results/results_simulations_bills.csv |
Updates expected bill results impacted by fan power changes. |
Review effort: Lite
…LabRockies/OpenStudio-HPXML into supp_coil_cycling_workaround
There was a problem hiding this comment.
🟡 Changes recommended
Backup-only fan-power scaling leaves CFIS using a runtime of 1, omitting ventilation-only fan energy in air-handler mode and overstating ventilation credit under optimized control.
1 open issue
4 resolved since last review
htg_supp_coil.nominalCapacityis typically an OptionalDouble in OpenStudio. Interpolating it into… These EMS conditionals compare floating-point sensors to0using exact equality (== 0). EMS… The YARD type annotations useXXXplaceholders (e.g., `CoilHeatingWaterToAirHeatPumpXXXEquationFit… Correct typo “mdeol” to “model”.
Review effort: Max
There was a problem hiding this comment.
🟡 Changes recommended
Runtime accounting still mishandles all-coils-off lockouts and backup-only CFIS operation, leaving spurious fan power and overstating duct losses and heating demand.
2 open issues
1 resolved since last review
Review effort: Max
There was a problem hiding this comment.
🟡 Changes recommended
The backup-only fan-power override lacks targeted timestep-level regression tests, leaving incorrect part-load scaling and overrides persisting into compressor heating or cooling insufficiently guarded against.
1 open issue
2 resolved since last review
Review effort: Max
| fan_power_program.addLine('If (SuppOnlyCyclingRuntimeFraction >= 0) && (SuppOnlyCyclingRuntimeFraction < 1)') | ||
| fan_power_program.addLine(" Set #{fan_press_actuator.name} = SuppOnlyCyclingRuntimeFraction * #{fan.designPressureRise}") |



Pull Request Description
Uses EMS to actuate the supply fan's power for heat pumps when only the backup is running (i.e., when the HP is locked out). Workaround for NatLabRockies/EnergyPlus#11903 where the supplemental coil is always assigned a runtime fraction of 1 even when it's really cycling.
Example of heating fan power before (blue) vs after (orange) for a dual-fuel heat pump:
Example of heating fan power before (blue) vs after (orange) for an all-electric heat pump:
In the above graph, Jan 7 has both HP and supplemental heating, so the fan power is correct, while Jan 1 and Jan 4 have only supplemental heating (HP is locked out due to the outdoor temperature), so the fan power gets adjusted.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run