Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for the PR. What calls |
|
Hi @puddly and thanks for the reply. wrt
I usually would agree, but I didn't see any other reasonable way. Which is why I documented "Architecture and design decisions" in each of the PRs to document the possibilities and thoughts and why some of them got discarded. Nevertheless, I'm very much open minded to any suggestions and discussions to simplify the whole topic and create PRs which are reasonable to merge. Feel free to ask anything and I'll either point you into one of the existing PRs descriptions or will answer it. Looking forward to a gr8 collaboration 💪 P.S: Thee PRs here are related to some other "Existing Bosch support" mentioned as well as the timezone PR we did in the past. Order was: first timezone, then common "bosch thermostat missing support" and then grand finale "weekly schedule" 😇 |
Proposed change
Add a typed weekly-schedule provider API to ZHA climate entities and implement the standard ZCL Thermostat-cluster schedule commands. Quirks opt in by declaring a registered schedule capability; device-family transport differences can be implemented behind the shared provider interface.
The provider supports fresh reads, explicit cache-only reads, schedule snapshots, validated seven-day uploads, per-day read-back verification, and clear operations. Uploads first read fresh heat limits and all seven days, then write and verify days serially. Partial failures report changed, unknown, and unattempted days; the library does not automatically retry or roll back. The thermostat's mode and clock are not changed.
The existing raw cluster-command API gains an opt-in response return, leaving calls that do not request a response unchanged.
Tests
Architecture and design decisions
WeeklyScheduleProviderand capability registry, with standard ZCL operations in a reusable provider; keep model-specific support in quirks.null) from known-empty ([]) days. The in-memory cache does not claim to detect changes made outside ZHA.Related pull requests
Existing Bosch support:
Weekly-schedule series:
zha-device-handlers— pending until the existing quirk PR #5714 is merged.