Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent runs for the same app/version can both pass the publish check and overwrite released images and the manifest because the full publishing sequence is not serialized.
1 open issue
What changed in this PR
This PR aims to prevent development merges from overwriting published addon releases when the configured version has not changed.
Changes:
- Checks whether the versioned Docker image already exists.
- Passes the resulting publish decision to image builds and multi-architecture manifest publication.
| File | Description |
|---|---|
.github/workflows/build-app.yaml |
Adds the image-existence check and gates publishing on its result. |
Review effort: Balanced
| VERSION: ${{ steps.normalize.outputs.version }} | ||
| PUBLISH: ${{ inputs.publish }} | ||
| run: | | ||
| if output=$(docker buildx imagetools inspect "${IMAGE}:${VERSION}" 2>&1); then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addon releases are a bit strange: every merge to
devbasically re-releases the current repo as the most recent release, overwriting the public image even if the version doesn't change. This means that we can't really develop indev...This PR skips replacing the Docker image if it already exists, so PRs that do not change
config.yaml'sversionkey do not re-publish. Supervisor will use the repos change log and README but that's a small price to pay.