Repository navigation
Improve C++ code: do not use int - #2071
Merged
Merged
Conversation
# Details - Do not use `int` in `worker/src` and `worker/include` because its width depends on the platform: Use a fixed-width type that matches the values it is compared or operated with. ## Bonus Tracks - Add `ms_log_dev_level` Meson option (0 to 3) to set the dev logging level of every source file that doesn't define its own `MS_LOG_DEV_LEVEL`. - Example: `MESON_ARGS="-Dms_log_dev_level=3" make`. - `mediasoup-worker.yaml` CI: Build with `-Dms_log_dev_level=3` in jobs that enable all Meson options. - `mediasoup-worker.yaml` CI: In jobs with `-Dms_log_dev_level=3`, write the test output to a log file and upload it as an artifact if the tests fail.
jmillan
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
intinworker/srcandworker/includebecause its width depends on the platform: Use a fixed-width type that matches the values it is compared or operated with.Bonus Tracks
ms_log_dev_levelMeson option (0 to 3) to set the dev logging level of every source file that doesn't define its ownMS_LOG_DEV_LEVEL.MESON_ARGS="-Dms_log_dev_level=3" make.mediasoup-worker.yamlCI: Build with-Dms_log_dev_level=3in jobs that enable all Meson options. This way we also compile the worker with full debug logs and verify that it compiles without errors or warnings.mediasoup-worker.yamlCI: In jobs with-Dms_log_dev_level=3, write the test output to a log file and upload it as an artifact if the tests fail.