Skip to content

Worker: Don’t take a template dependency structure older than the one in use - #2047

Merged
jmillan merged 5 commits into
v3from
dd-context
Nov 10, 2026
Merged

jmillan merged 5 commits into
v3from
dd-context

Conversation

@jmillan

@jmillan jmillan commented Nov 9, 2026

Copy link
Copy Markdown
Member

Fixes the issue mentioned here: #2015 (comment)

DependencyDescriptor::Parse() handed the stream the structure of every descriptor it parsed. A retransmitted or reordered packet of an old key frame thus replaced the one in use, leaving every following packet parsed with outdated templates (wrong layers and wrong decode target indications) until the next key frame. It is now taken only from the first packet of a frame that is not older than the one that brought the structure in use.

jmillan and others added 2 commits November 9, 2026 16:41
… in use

Fixes the issue mentioned here: #2015 (comment)

DependencyDescriptor::Parse() handed the stream the structure of every descriptor it parsed. A retransmitted or reordered packet of an old key frame thus replaced the one in use, leaving every following packet parsed with outdated templates — wrong layers and wrong decode target indications — until the next key frame.
It is now taken only from the first packet of a frame that is not older than the one that brought the structure in use, which takes following the unwrapped frame numbers of the stream along with it. The packet is forwarded all the same, since it’s the endpoint who decides what to do with it.
@jmillan
jmillan merged commit df91ad6 into v3 Nov 10, 2026
49 checks passed
@jmillan
jmillan deleted the dd-context branch November 10, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants