Repository navigation
Worker: Don’t take a template dependency structure older than the one in use - #2047
Merged
Merged
Conversation
… in use Fixes the issue mentioned here: #2015 (comment) DependencyDescriptor::Parse() handed the stream the structure of every descriptor it parsed. A retransmitted or reordered packet of an old key frame thus replaced the one in use, leaving every following packet parsed with outdated templates — wrong layers and wrong decode target indications — until the next key frame. It is now taken only from the first packet of a frame that is not older than the one that brought the structure in use, which takes following the unwrapped frame numbers of the stream along with it. The packet is forwarded all the same, since it’s the endpoint who decides what to do with it.
8 of 9 tasks
ibc
reviewed
Nov 9, 2026
ibc
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned here: #2015 (comment)
DependencyDescriptor::Parse() handed the stream the structure of every descriptor it parsed. A retransmitted or reordered packet of an old key frame thus replaced the one in use, leaving every following packet parsed with outdated templates (wrong layers and wrong decode target indications) until the next key frame. It is now taken only from the first packet of a frame that is not older than the one that brought the structure in use.