Skip to content

fix: decode percent-encoded proxy credentials - #2389

Merged
lahfir merged 4 commits into
mainfrom
laf/decode-proxy-credentials
Nov 4, 2026
Merged

lahfir merged 4 commits into
mainfrom
laf/decode-proxy-credentials

Conversation

@lahfir

@lahfir lahfir commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
  1. Percent-encoded proxy credentials were sent literally, causing authentication to fail.
  2. Decode proxy URL credentials once in the shared parser used by the CLI and MCP.
  3. Builds on fix: percent-decode proxy credentials #2073.

Co-authored by @alkaz-nodemaven, based on #2073.

Before

A URL-encoded password fails the proxy's authentication challenge.

before.mp4

After

The proxy receives the decoded password and the page opens.

after.mp4

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
agent-browser Ready Ready Preview, v0 Nov 4, 2026 2:09am UTC
agent-browser-env-demo Ready Ready Preview, v0 Nov 4, 2026 2:09am UTC

lahfir and others added 4 commits November 3, 2026 18:05
Decode the username and password after splitting proxy URL userinfo so authentication receives the intended characters.

Co-Authored-By: Alexandr Kazmin <316548136+alkaz-nodemaven@users.noreply.github.com>
@lahfir
lahfir merged commit 6682da3 into main Nov 4, 2026
19 checks passed

This branch was successfully deployed

2 active deployments
Preview – agent-browser-env-demo — bdaf0cf3 Deployed Nov 4, 2026 by vercel[bot]
Preview – agent-browser — bdaf0cf3 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants