Skip to content

Fix German ICU message formatting - #3144

Merged
engram-design merged 1 commit into
verbb:craft-5from
Yxanu:fix/german-icu-messages
Nov 19, 2026
Merged

engram-design merged 1 commit into
verbb:craft-5from
Yxanu:fix/german-icu-messages

Conversation

@Yxanu

@Yxanu Yxanu commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

I found eight German messages with translated ICU keywords or parameter names. This fixes the patterns and adds singular/plural regression coverage for validation messages, date offsets and recurring intervals.

All 16 cases fail against the original translations. They pass after the fix on PHP 8.2.29 and 8.4.14, including after rebasing onto craft-5. These are isolated unit runs using the repository's locked Pest dependencies, not a full Craft integration run.

The existing English keys and other languages are unchanged.

@engram-design
engram-design merged commit e26f674 into verbb:craft-5 Nov 19, 2026
@engram-design

Copy link
Copy Markdown
Member

Thanks!

engram-design added a commit that referenced this pull request Nov 19, 2026
…in German, Spanish, French, Italian and Portuguese. (#3144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants