Repository navigation
Fix German ICU message formatting - #3144
Merged
Merged
Conversation
Member
|
Thanks! |
engram-design
added a commit
that referenced
this pull request
Nov 19, 2026
…in German, Spanish, French, Italian and Portuguese. (#3144)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found eight German messages with translated ICU keywords or parameter names. This fixes the patterns and adds singular/plural regression coverage for validation messages, date offsets and recurring intervals.
All 16 cases fail against the original translations. They pass after the fix on PHP 8.2.29 and 8.4.14, including after rebasing onto craft-5. These are isolated unit runs using the repository's locked Pest dependencies, not a full Craft integration run.
The existing English keys and other languages are unchanged.