[sosthene-nitrokey]

This is useful in tests to make sure that there is not memory/storage leak for example.

[robin-nitrokey]

What do you think about storing the callback in a Box and adding it as a field to the runner instead of adding all the *_with_cleanup variations?

[sosthene-nitrokey]

We could make it part of the runner, but most downstreams don't use it directly and they use the Platform instead through with_platform, then run_client*.

For exemple the piv-authenticator test suite never sees a Runner value.
So the duplication in the run_client* would still be needed.

[robin-nitrokey]

Couldn’t we make it a field for both Platform and Runner to solve this issue? So instead of:

platform.run_client_with_backends_and_cleanup(..., cleanup)

we could have:

platform.cleanup(cleanup).run_client_with_backends(...)

This would also cause some duplication, but I think it’s much easier to manage than adding another variant to the run_with_* functions.

[robin-nitrokey]

That’s even better, thanks.