Repository navigation
🐛 fix(workflows): skip timestamp-only lock refreshes - #52
Merged
Merged
Conversation
Nab rewrites `created-at` in every lock it writes, so a refresh with no dependency change still left a one-line diff, and upgrade-release-tools and update-python-dependencies opened a pull request for it (toml-fmt #519). Both now restore a lock whose only changed line is `created-at` before deciding whether anything changed. The check counts the changed lines rather than stopping at the first match, so a large lock diff can't end the pipeline early and be mistaken for a timestamp-only one.
gaborbernat
enabled auto-merge (squash)
November 4, 2026 23:15
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nab rewrites
created-atin every lock it writes, so a refresh with no dependency change still leaves a one-line diff.upgrade-release-toolsandupdate-python-dependenciesthen open a pull request whose only change is that timestamp (toml-fmt#519).Before deciding whether anything changed, both now restore any lock whose only changed line is
created-at:refresh-release-lockfor its locks outsidecheckmode, andupdate-python-dependenciesfor every changed*pylock*.tomlbefore staging. The check counts the non-timestamp lines withgrep -cinstead of stopping at the first match withgrep -q. Underpipefail, an early exit can SIGPIPE the upstream command and would make a large real change look timestamp-only.