Skip to content

Reuse admitted paragraph IDs during insertion replay - #3215

Queued
jan-kubica wants to merge 2 commits into
mainfrom
perf/reuse-admitted-paragraph-ids
Queued

jan-kubica wants to merge 2 commits into
mainfrom
perf/reuse-admitted-paragraph-ids

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • Reuse the exact paragraph ID already admitted for a single-paragraph insertion when replay reorders an eligible window.
  • Give the ordinary paragraph compiler a one-ID range. Keep the existing revision allocation, placement, formatting, validation and receipt paths.
  • Use ordinary sibling reservations for mixed windows, real leases, suggestions and any member whose introduced identity cannot be verified.

Verification

  • Public comparisons cover before and redirected-after placement, mixed-case and retired IDs, exact compiled operations and receipts, undo, and partial revision exhaustion.
  • Work counts at 12, 24 and 48 operations assert a linear number of paragraph-ID formatting calls during replay.
  • Boundary and mixed-window cases confirm native exhaustion and a single window-level fallback.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: stella/folio
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: da26693
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2797a96b-2ded-42c8-ab6c-e62312cccc38
Commits

Reviewing files that changed from the base of the PR and between da26693 and 17dedf8.

Files selected for processing: 4

  • .changeset/reuse-admitted-paragraph-ids.md
  • packages/core/src/canonical/canonicalInsertionReplayIds.test.ts
  • packages/core/src/canonical/canonicalInsertionReplayIds.ts
  • packages/core/src/canonical/canonicalPublicOperations.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-20T20:33:36.762058Z 7b993c9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jan-kubica
jan-kubica enabled auto-merge November 20, 2026 20:29
@jan-kubica
jan-kubica added this pull request to the merge queue Nov 20, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant