Skip to content

fix(docx-core): let the paragraph before a rejected inserted cell-final paragraph end the cell - #3185

Merged
jan-kubica merged 1 commit into
mainfrom
fix/reject-inserted-cell-final-paragraph
Nov 20, 2026
Merged

jan-kubica merged 1 commit into
mainfrom
fix/reject-inserted-cell-final-paragraph

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor
  • Rejecting an inserted mark on a cell's final paragraph, left empty by the resolution, now removes that paragraph when a paragraph precedes it, so the preceding paragraph ends the cell (the same rule as other containers). Previously the cell kept an extra empty paragraph.
  • A cell's only paragraph still stays as its terminator.
  • Tests: the cell case, a cell whose text was replaced by an inserted paragraph, and the sole-paragraph case.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: stella/folio
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 5e26c01
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 923d1cf6-0d3c-41a7-9b64-7be12106ead8
Commits

Reviewing files that changed from the base of the PR and between 5e26c01 and 52da160.

Files selected for processing: 3

  • .changeset/inserted-cell-final-paragraph-reject.md
  • packages/docx-core/src/ops/__tests__/paragraphMarkCarrier.test.ts
  • packages/docx-core/src/ops/resolve.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@jan-kubica
jan-kubica enabled auto-merge November 20, 2026 17:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-20T17:37:54.042874Z 52da160 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jan-kubica
jan-kubica added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit d912d3d Nov 20, 2026
37 checks passed
@jan-kubica
jan-kubica deleted the fix/reject-inserted-cell-final-paragraph branch November 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant