Skip to content

fix(docx-core): take back a pending record only as its own author and suggestion - #3087

Queued
jan-kubica wants to merge 3 commits into
mainfrom
fix/suggestion-own-revision
Queued

jan-kubica wants to merge 3 commits into
mainfrom
fix/suggestion-own-revision

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor
  • A suggestion deleting or replacing over its author's ordinary pending insertion (or another suggestion's) removed that insertion outright, so rejecting the suggestion, or saving without pending suggestions, lost the words or the paragraph.
  • isOwnRecord (ops/revisionOwner.ts) decides ownership as the same author and the same suggestion; every own-record check (range deletion planning, tracked joins, block deletion, table rows and cells, whole-paragraph replacement, revision grouping, tracked transform) goes through it.
  • A source-scan test keeps author-only comparisons out of the operations.
  • Tests: a suggested replacement, deletion and paragraph deletion over an ordinary insertion of the same author are rejectable.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: stella/folio
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: e82e839
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6518e7e-b068-408c-9ca0-7a6616ff830b
Commits

Reviewing files that changed from the base of the PR and between e82e839 and bc4bf67.

Files selected for processing: 14

  • .changeset/suggestion-own-revision.md
  • packages/core/src/canonical/canonicalSession.ts
  • packages/docx-core/src/ops/__tests__/suggestionOverOwnInsertion.test.ts
  • packages/docx-core/src/ops/__tests__/wholeParagraphReplacement.test.ts
  • packages/docx-core/src/ops/apply.ts
  • packages/docx-core/src/ops/blockDeletion.ts
  • packages/docx-core/src/ops/plan.ts
  • packages/docx-core/src/ops/rangeReplacement.ts
  • packages/docx-core/src/ops/revisionGrouping.ts
  • packages/docx-core/src/ops/revisionOwner.ts
  • packages/docx-core/src/ops/sequencing/trackedTransform.ts
  • packages/docx-core/src/ops/tableOwnPending.ts
  • packages/docx-core/src/ops/tableRows.ts
  • packages/docx-core/src/ops/wholeParagraphReplacement.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-20T12:50:13.770515Z b7afad6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jan-kubica
jan-kubica enabled auto-merge November 20, 2026 12:45
@jan-kubica
jan-kubica added this pull request to the merge queue Nov 20, 2026
Any commits made after this event will not be merged.
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
…vision

# Conflicts:
#	packages/docx-core/src/ops/apply.ts
@jan-kubica
jan-kubica enabled auto-merge November 20, 2026 14:26
@jan-kubica
jan-kubica added this pull request to the merge queue Nov 20, 2026
Any commits made after this event will not be merged.
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
@jan-kubica
jan-kubica enabled auto-merge November 20, 2026 17:28
# Conflicts:
#	packages/docx-core/src/ops/blockDeletion.ts
@jan-kubica
jan-kubica added this pull request to the merge queue Nov 20, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant