Skip to content

style: add missing whitespace - #16531

Merged
kgryte merged 2 commits into
developfrom
claude/trusting-cannon-12fxz3
Nov 8, 2026
Merged

kgryte merged 2 commits into
developfrom
claude/trusting-cannon-12fxz3

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-11-06T02:00Z and 2026-11-07T02:05Z to sibling packages.
  • adds the missing space before a closing parenthesis in documentation examples and signatures, mirroring 8f624de and 34d508a (style: add missing whitespace). Targets:
    • math/base/tools/hermitepoly (README example require call)
    • stats/base/dists/weibull/logcdf (repl.txt factory signature)
    • blas/ext/base/wasm/dapxsum, blas/ext/base/wasm/dapxsumkbn, blas/ext/base/wasm/dapxsumors, blas/ext/base/wasm/dapxsumpw, blas/ext/base/wasm/sapxsumkbn (repl.txt view-offset example)

Related Issues

Does this pull request have any related issues?

None.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • stats/base/dists/weibull/cdf and blas/ext/base/wasm/dapx, which already use the spaced form.

What carried over from the reference(s)?

  • Spacing convention for call and signature parentheses.

What differed, or what did you have to work out yourself?

  • Nothing.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: candidates came from a pattern search across README.md, docs/repl.txt, docs/types/index.d.ts, lib/*.js, and examples/*.js. Two independent reviewers confirmed every site, and a style-consistency pass approved each patch as written. Each change inserts one space and touches nothing else.

Excluded on purpose: test files, which hold about 170 matches and are broader than the source commits' documentation scope; generator scripts (ndarray/base/nullary/scripts/loops.js, strided/base/nullary/scripts/loops.js); the intentionally invalid example in _tools/eslint/rules/require-spaces; and docs/types/test.ts.

The other candidate commits in the window had no remaining sibling sites: the fileystem and paramater typos, the stray ) after [ndarray][@stdlib/ndarray/ctor], and the repl_text.md underline.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from 8f624de ("style: add missing whitespace") and 34d508a ("style: add missing whitespace") to sibling documentation with the same missing space before a closing parenthesis.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BhLevGn8SvFGQq2FR
Reverts the whitespace propagation in `blas/ext/base/wasm/{dapxsum,dapxsumkbn,dapxsumors,dapxsumpw,sapxsumkbn}` and `stats/base/dists/weibull/logcdf` `repl.txt` files. Touching these files surfaces pre-existing lint errors (`no-redeclare` and `doctest`) unrelated to the propagated fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BhLevGn8SvFGQq2FR
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 7, 2026
@Planeshifter Planeshifter changed the title style: add missing whitespace in blas, math, and stats docs style: add missing whitespace in math/base/tools/hermitepoly Nov 7, 2026

Copy link
Copy Markdown
Member Author

Lint Changed Files failed on 24e25ce. The changed lines did not cause it: touching these files ran the repl.txt linter on them, and it reported errors that were already there.

  • blas/ext/base/wasm/{dapxsum,dapxsumkbn,dapxsumors,dapxsumpw,sapxsumkbn}/docs/repl.txt: no-redeclare. The .ndarray examples redeclare var x.
  • stats/base/dists/weibull/logcdf/docs/repl.txt: doctest. The pinf example shows 0.0, but the doctest expects -0.0.

Fixing those errors is outside this propagation, so e5d73b5 reverts the six repl.txt files. This PR is now the one-line hermitepoly README fix. The errors listed above remain on develop.


Generated by Claude Code

@stdlib-bot

stdlib-bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/tools/hermitepoly $\\color{green}202/202$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}202/202$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review November 8, 2026 08:45
@kgryte
kgryte requested a review from a team November 8, 2026 08:45
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 8, 2026
@kgryte kgryte changed the title style: add missing whitespace in math/base/tools/hermitepoly style: add missing whitespace Nov 8, 2026
@kgryte
kgryte merged commit 2a44431 into develop Nov 8, 2026
50 checks passed
@kgryte
kgryte deleted the claude/trusting-cannon-12fxz3 branch November 8, 2026 08:46
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants