Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #519 -- this PR is stacked on top of #523 as JUCE added support for Windows ARM64 in 7.0.3. I can rebase this PR when that one is merged.
For the plugin binaries that are used for testing, I have added a workflow with a manual trigger,
.github/workflows/build-windows-test-plugins.yml, which can build and optionally commit those files, either for ARM64 only or for x64 as well. Until those are committed, I added a commit which lowers the coverage minimum, only on Windows ARM64; this can be reverted or removed once the binaries are in. The build script also applies a couple of patches needed for JUCE 7:Thread::PriorityAPI change in the GUI library CHOWTapeModel bundles.buffer.clear()in Magical8bitPlug2. Without it, output builds up from block to block under JUCE 7.Some more notes:
sys.base_prefixinstead of a hard-coded x64 path..vst3/Contents/x86_64-win/.All builds/tests pass (that workflow run is from a branch where I ran the VST build workflow so the binaries are on that branch, and I removed the coverage-reduction commit).
Closes #519.