Skip to content

Remove legacy helpers and add kicker actions - #109

Merged
joaovictor-ferreira merged 4 commits into
masterfrom
remove-legacy-helpers-and-add-kicker-actions
Oct 5, 2026
Merged

joaovictor-ferreira merged 4 commits into
masterfrom
remove-legacy-helpers-and-add-kicker-actions

Conversation

@joaovictor-ferreira

@joaovictor-ferreira joaovictor-ferreira commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

This PR aligns DssExecLib with the active Kicker-based surplus-processing architecture and removes helpers for legacy or operationally inactive paths:

  • Adding kicker() to resolve MCD_KICK and extending the internal Fileable interface with signed parameter support
  • Replacing the obsolete Vow bump and hump helpers with setKickerAuctionAmount and setKickerSurplusBuffer, converting whole USDS inputs to RAD and preserving signed khump values
  • Removing govGuard(), the legacy flip(bytes32) alias, and the operationally inactive DDM target-rate helper
  • Expanding tests for Kicker address resolution, unit conversion, negative, zero, and positive thresholds, boundary rejection, state preservation, and parameter isolation
  • Updating the NatSpec and README documentation

@joaovictor-ferreira joaovictor-ferreira self-assigned this Aug 24, 2026
@joaovictor-ferreira
joaovictor-ferreira marked this pull request as ready for review August 24, 2026 20:27

@amusingaxl amusingaxl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the deployed Kicker/Splitter path, current mainnet configuration, authorization, conversions, boundary behavior, and downstream consumers.

I found no blocking issues. The new signed setter matches Kicker’s ABI and parameter semantics, and the removed helpers have no active consumers.

Local formatting/build checks passed and the full fork suite passed..

@0xLaz3r 0xLaz3r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@joaovictor-ferreira
joaovictor-ferreira merged commit 1f195b4 into master Oct 5, 2026
3 checks passed
@joaovictor-ferreira
joaovictor-ferreira deleted the remove-legacy-helpers-and-add-kicker-actions branch October 5, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants