Repository navigation
Remove legacy helpers and add kicker actions - #109
Merged
joaovictor-ferreira merged 4 commits intoOct 5, 2026
Merged
Conversation
amusingaxl
approved these changes
Sep 2, 2026
amusingaxl
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the deployed Kicker/Splitter path, current mainnet configuration, authorization, conversions, boundary behavior, and downstream consumers.
I found no blocking issues. The new signed setter matches Kicker’s ABI and parameter semantics, and the removed helpers have no active consumers.
Local formatting/build checks passed and the full fork suite passed..
joaovictor-ferreira
deleted the
remove-legacy-helpers-and-add-kicker-actions
branch
October 5, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns
DssExecLibwith the active Kicker-based surplus-processing architecture and removes helpers for legacy or operationally inactive paths:kicker()to resolveMCD_KICKand extending the internalFileableinterface with signed parameter supportbumpandhumphelpers withsetKickerAuctionAmountandsetKickerSurplusBuffer, converting whole USDS inputs toRADand preserving signedkhumpvaluesgovGuard(), the legacyflip(bytes32)alias, and the operationally inactive DDM target-rate helper