Repository navigation
Conversation
The reader of a playback adds to each packet's duration the difference between its PTS and the PTS the previous packet ended at, to make up for rounding. next_pts is never reset, so after a seek that difference is the whole jump: the packet after the seek gets a duration wrong by it, and the adjustment of every later packet carries the error on. A new player started at a start-pos sends its first packet and is then silent for about as long as its start position. After the seek back to the start of a repeated file the reader runs in bursts; an audio player mixes what it is given as it comes, so from the second time round only part of each frame is mixed with the other sources. A reader that seeks now forgets the PTS it expected, so the packet after the seek is taken at its own duration. auto-daemon-tests-inject.pl plays a file from a start position and repeats one into an injection, and checks what the receiver gets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reader of a playback adds to each packet's duration the difference between its PTS and the PTS the previous packet ended at, to make up for rounding.
next_ptsis never reset, so after a seek that difference is the whole jump: the packet after the seek gets a duration wrong by it, and the adjustment of every later packet carries the error on.A new player started at a
start-possends its first packet and is then silent for about as long as its start position. After the seek back to the start of a repeated file the reader runs in bursts; an audio player mixes what it is given as it comes, so from the second time round only part of each frame is mixed with the other sources.A reader that seeks now forgets the PTS it expected, so the packet after the seek is taken at its own duration.
auto-daemon-tests-inject.plplays a file from a start position and repeats one into an injection, and checks what the receiver gets.