Repository navigation
Conversation
redis_tags() restores each monologue's label into ml->label but does not add it to call->labels. Commands that address a call party by label find it only there (media_match()), so on a call restored from Redis they fail with "No monologue matching the given label", although "query" still reports the label. Label-addressed commands such as start/stop forwarding or block/unblock media fail after a takeover until a new offer or answer sets the label again. Add the label to call->labels, as offer/answer, set-label and the merging of calls do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis_tags() restores each monologue's label into ml->label but does not add it to call->labels. Commands that address a call party by label find it only there (media_match()), so on a call restored from Redis they fail with "No monologue matching the given label", although "query" still reports the label. Label-addressed commands such as start/stop forwarding or block/unblock media fail after a takeover until a new offer or answer sets the label again.
Add the label to call->labels, as offer/answer, set-label and the merging of calls do.
fix was checked with a takeover test that fails without it.