Skip to content

redis: index the labels of restored monologues - #2247

Closed
pphm-e wants to merge 1 commit into
sipwise:masterfrom
pphm-e:redis-index-restored-monologue-labels
Closed

pphm-e wants to merge 1 commit into
sipwise:masterfrom
pphm-e:redis-index-restored-monologue-labels

Conversation

@pphm-e

@pphm-e pphm-e commented Nov 17, 2026

Copy link
Copy Markdown

redis_tags() restores each monologue's label into ml->label but does not add it to call->labels. Commands that address a call party by label find it only there (media_match()), so on a call restored from Redis they fail with "No monologue matching the given label", although "query" still reports the label. Label-addressed commands such as start/stop forwarding or block/unblock media fail after a takeover until a new offer or answer sets the label again.

Add the label to call->labels, as offer/answer, set-label and the merging of calls do.

fix was checked with a takeover test that fails without it.

redis_tags() restores each monologue's label into ml->label but does not
add it to call->labels. Commands that address a call party by label find
it only there (media_match()), so on a call restored from Redis they fail
with "No monologue matching the given label", although "query" still
reports the label. Label-addressed commands such as start/stop forwarding
or block/unblock media fail after a takeover until a new offer or answer
sets the label again.

Add the label to call->labels, as offer/answer, set-label and the merging
of calls do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant