Skip to content

Bump mettle payloads to 1.0.49 - #22159

Merged
dwelch-r7 merged 1 commit into
rapid7:masterfrom
dwelch-r7:bump-mettle-1.0.49
Nov 18, 2026
Merged

dwelch-r7 merged 1 commit into
rapid7:masterfrom
dwelch-r7:bump-mettle-1.0.49

Conversation

@dwelch-r7

Copy link
Copy Markdown
Contributor

Description

Bump metasploit_payloads-mettle from 1.0.48 to 1.0.49, updating the gemspec and lockfile.

This release includes rapid7/mettle#299. It keeps the EIO completion watcher active so restarting it cannot discard a worker notification and strand completed filesystem or HTTP requests. This addresses the notification race implicated in intermittent mettle acceptance timeouts.

AI tools: OpenAI Codex prepared the dependency bump, inspected release provenance, and performed the local verification below.

Verification

  • Run bundle install, then bundle exec ruby -rmetasploit_payloads/mettle -e 'puts Gem.loaded_specs.fetch("metasploit_payloads-mettle").version'; confirm 1.0.49.
  • Confirm the Linux and macOS mettle jobs in Meterpreter Acceptance pass using the released gem.

Results and evidence

  • The release pipeline completed successfully and RubyGems published 1.0.49 on 18 November 2026.
  • A conservative Bundler update changed only mettle's version entries. The release adds no runtime gem dependencies.
  • Bundler loaded metasploit_payloads-mettle 1.0.49. The downloaded gem matched RubyGems' SHA-256: e156e351ae7060493cd49869d19725e7468a13998b90c36248e8a39e89823111.
  • Generated a Linux x64 reverse-HTTP ELF with minimal_uris_headers.profile and a macOS x64 reverse-TCP Mach-O successfully.
  • Inspected the released Intel macOS binary: eio_done_poll is a no-op and eio_async_cb no longer restarts the async watcher.
  • Gemspec syntax and git diff --check passed. GitHub CI will provide the full integration results; local payload generation did not establish live sessions.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated a runtime dependency to a newer version.

The gemspec changes the required metasploit_payloads-mettle runtime dependency version from 1.0.48 to 1.0.49.

Changes: Runtime Dependency Update

Layer / File(s) Summary
Update runtime dependency version
metasploit-framework.gemspec
The required metasploit_payloads-mettle runtime dependency version changes from 1.0.48 to 1.0.49.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: zerosteiner

Merge Risk: Minimal · up to 7b17c

This updates the Mettle payloads dependency to 1.0.49 to pick up an upstream fix for a notification race. The gemspec and lockfile agree. No actionable merge risk was found; CI acceptance results should confirm it.

Architecture risk: Low · up to 7b17c

The change affects 1 system.

Changed systems: metasploit-framework.gemspec

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — metasploit-framework.gemspec (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in metasploit-framework.gemspec: The required version of the metasploit_payloads-mettle runtime dependency changes from 1.0.48 to 1.0.49.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Bump mettle payloads to 1.0.49" names the change, which is a version bump of the metasploit_payloads-mettle dependency from 1.0.48 to 1.0.49 in metasploit-framework.gemspec. It also names t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Pr Description And Verification Passed The PR description meets the custom check. - What and why: It states the change. The metasploit_payloads-mettle gem goes from 1.0.48 to 1.0.49 in the gemspec and lockfile. It gives the reason: r…
Full details: Title check

Explanation

The title "Bump mettle payloads to 1.0.49" names the change, which is a version bump of the metasploit_payloads-mettle dependency from 1.0.48 to 1.0.49 in metasploit-framework.gemspec. It also names the affected component (mettle payloads). The title meets the stated requirement to describe the actual change and affected component, and it has no required prefix or length limit.

Full details: Pr Description And Verification

Explanation

The PR description meets the custom check. - What and why: It states the change. The metasploit_payloads-mettle gem goes from 1.0.48 to 1.0.49 in the gemspec and lockfile. It gives the reason: rapid7/mettle#299 keeps the EIO completion watcher active. The author ties this to intermittent mettle acceptance timeouts. - Verification steps with expected outcome: The unchecked item gives a concrete command: bundle install, then a Ruby one-liner that prints the loaded gem version. The expected result is 1.0.49. A second item names the Meterpreter Acceptance jobs for Linux and macOS as the expected CI check. - Actual results: The author reports these results: - RubyGems published 1.0.49. - Bundler loaded 1.0.49. - The downloaded gem's SHA-256 matched RubyGems. - A Linux x64 reverse-HTTP ELF and a macOS x64 reverse-TCP Mach-O generated successfully. - The released Intel macOS binary was inspected for the eio_done_poll and eio_async_cb changes. - Gemspec syntax and git diff --check passed. - Untested limits: The description says local payload generation did not establish live sessions. It says the Meterpreter Acceptance results come from GitHub CI. The raw summary matches the description. It reports a one-line version change in the gemspec, so the stated scope is consistent. Unchecked verification boxes are expected under the check. I did not re-run the author's commands or verify the external release facts. The check does not require that.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 31e0ef3 and 7b17c2b.

Files ignored due to path filters: 1

  • Gemfile.lock is excluded by !**/*.lock
Files selected for processing: 1

  • metasploit-framework.gemspec

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Metasploit Kanban Nov 18, 2026
@dwelch-r7 dwelch-r7 added the rn-no-release-notes no release notes label Nov 18, 2026
@dwelch-r7
dwelch-r7 merged commit f4cb5e6 into rapid7:master Nov 18, 2026
73 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Metasploit Kanban Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn-no-release-notes no release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants