Repository navigation
Use the selected site base URL for the static page preview - #556
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the v3 editor,
pagePreviewUrl()builds the preview link withUrl::to(), which uses the host of the current backend request. With multisite, when the backend runs on one site's domain and another site is selected in the site picker, Preview opens the page on the backend's domain instead of the selected site. In v2,getPreviewPageUrl()usedCms::fullUrl(), which resolves the edit site's base URL.Fix
Use
Cms::fullUrl()again, so the preview uses the base URL of the site selected in the backend. The v2cms.sitePicker.overridePatternhook is not restored here; happy to add it if wanted.Test
Added
PreviewUrlTestwith a second site on its own domain. It fails without the fix (request host) and passes with it; the full suite passes.