Repository navigation
Store the default layout when saving a new static page - #555
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A new page saved in the v3 editor without choosing a layout gets no
layoutin its file.setDefaultLayout()runs afterfill()and only updates the view bag component, while the file is written from theviewBagattribute.Without a stored layout,
getLayoutObject()falls back to the first layout fromLayout::listInTheme(). That order comes fromRecursiveDirectoryIteratorand depends on the filesystem: alphabetical on macOS, unordered on Linux (ext4). On a Linux server a new page can end up on another layout (e.g.error.htm). The save response still uses the in-memory layout, so the editor shows the syntax tab, but the island loads the page from disk and renders none of its fields.Fix
Resolve the default layout before
fill()and add it to the posted settings, so it is written to the page file, like pages created with v2.Test
Added
NewPageLayoutTest. It fails without the fix (layout isnull); with the fix the full suite passes (85 tests).Steps to reproduce
default = 1, where the other is listed first on disk.layout; the other layout is used.