Repository navigation
Validate X-ray energy and wavelength inputs - #153
Open
swf1996120 wants to merge 1 commit into
Open
swf1996120 wants to merge 1 commit into
swf1996120 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chemical repository testing study: validate X-ray conversion domains
This pull request addresses #152.
xray_wavelength()andxray_energy()now reject zero, negative, NaN, and infinite inputs withValueError. Valid scalar and vector inputs retain the current conversion behavior. This prevents nonphysical values from propagating into X-ray scattering-factor, SLD, and refractive-index calculations.Tests cover the invalid scalar domain and confirm vector support.
Testing disclosure: this patch was developed as part of an LLM-assisted chemical repository testing study. The candidate cases were generated with LLM assistance, then reproduced locally, minimized, and fixed with a focused validation patch and tests.