Repository navigation
Fix rem zero divisors and signed zshr results - #60
Merged
Merged
Conversation
Update bugfixes section with new issue references and clarify behavior changes.
garyb
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58 and addresses the library portion of #59.
When its divisor is zero
Data.Int.remreturnsNaN, despite theIntreturn type; this behavior differs fromquot and Prelude'smod. To bring it in line this PR coerces the result with| 0`.I applied the same to
Data.Int.Bits.zshr. This is a behavioral change because shifting a negative input by zero or a multiple of 32 now returns the original signed input, instead of returning an unsigned number.The
zshrfix won't work without an accompanying compiler change because purs inlines direct calls as raw>>>, bypassing this library implementation altogether; so both the library and compiler fix are needed to fully resolve #59.