[MichaelDim02]

Connection initialization stalls because of an early return on empty disco#items responses.

I encountered this issue when attempting to add a room as a bookmark, which would report success but no bookmark was actually added, with the logs reporting an empty storage field sent to the server. Apparently the bookmarks table was never initialized, as bookmark_request() was never triggered. I traced this to the early exit on _disco_items_result_handler().

This patch fixes the immediate user-facing issue of adding persistent bookmarks. However, merely calling sv_ev_connection_features_received(); on an empty table may not be a complete compensation for initialization, and whether initialization order is respected needs to be examined. Long term, a shared handler may be more appropriate. I decided to leave that decision up to the maintainers.

• I ran valgrind when using my new feature

How to test the functionality

• Connect to a server that returns an empty disco#items response
• Add a room bookmark using /bookmark add room@conference.example.org autojoin on.
• Verify that /bookmark list displays the newly added room.
• Disconnect and reconnect, then verify that the bookmark is retrieved and the room is automatically joined.

[jubalh]

I just started to work on that part of the code and pushed a PR one day before your opened this one. Please take a look at #2251

It's not quite finished yet. I still need to check a couple of things before merging.

[jubalh]

Thanks for your effort.
After reviewing I see this is addressed in #2251 as well. So I'll close in favour of that PR.