Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Metal bench (arm64) passed. All 517 measures within bounds.
Counters per txn
Microbench: all 504 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json Compared 3d93c4d with 2131844 on c8g.metal-24xl (on-demand). |
Contributor
|
Metal bench (x86) passed. All 517 measures within bounds.
Counters per txn
Microbench: all 504 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subquery test suite runs statements against both us and Postgres, and then compares the responses to ensure exact wire protocol conformity.
Previously, I only opted to support asserting the kind (select, delete, update, etc) of statement and which shards those statements were sent to (e.g.,
-- route select: 0,1expecting a select to be sent to both shard 0 and 1). This, however, does not give us the capability to truly ensure queries are being sent as we expect (if for some reason the re-write returned correct rows in our specific test case, but wouldn't otherwise due to being incorrectly rewritten), e.g., fetchingsubuserswithSELECT *vs. withSELECT id, status.Now, this adds support for an optional
-- sql:comment assertion right after a-- routecomment assertion.E.g., if we have a case such as
this is now able to check that both shards run the subquery first, and then that the outer statement is ran with the ids in
unnest(..)(as opposed to VALUES, not being re-written at all, etc)This was fairly easy to add as the route assertions use pg_stat_monitor, and there was pre-existing 'machinery' to get the exact query ran (previously used get the statement type)