Repository navigation
perf: migrate WHERE subqueries to unnest - #2023
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
|
Metal bench (arm64) passed. All 517 measures within bounds.
Counters per txn
Microbench: all 504 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json |
Contributor
|
Metal bench (x86) passed. All 517 measures within bounds.
Counters per txn
Microbench: all 504 measures within bounds. Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json Compared 01843f6 with 6d7adec on c7i.metal-48xl (on-demand). |
jkaczman
added a commit
that referenced
this pull request
Nov 13, 2026
…2024) When we send CTE subselects to be evaluated separately from the top-level query, sometimes the subselects reference earlier executed CTEs (e.g., CTE b references CTE a). When we send CTE b, we need to include the values that CTE a previously returned; this is done via re-writing the CTE b subselect to include a WITH clause with CTE a's returned values, so that when we execute it separately from the top-level query, it has everything it needs to return the values it should. Right now, this is done with a VALUES clause with all the DataRows inlined as tuples. Example, > WITH a (id, status) AS (VALUES (1::bigint, 'VIP'::text), (2, 'regular')) SELECT x.id, y.id FROM a x JOIN a y ON x.status = y.status This migrates those from VALUES to unnest (via Bind param array) for massive speedup (follow up to #2003, #2023).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2003 to additionally migrate WHERE subqueries to use unnest instead of inlining the data within the SQL query (e.g., previously,
IN ('Data Row 1', 'Data Row 2', 'Data Row 3')). Now, they're specified within a Bind parameter array via unnest (massive speedup).