Repository navigation
perf: reduce clock reads per request from 9 to 3 - #2016
Merged
Merged
Conversation
levkk
reviewed
Nov 11, 2026
| self.statement_executed | ||
| } | ||
|
|
||
| pub(crate) fn take_last_ready_for_query(&mut self) -> Option<Instant> { |
Collaborator
There was a problem hiding this comment.
nit: I'd rename it to something more self-documenting, maybe take_last_query_exec_time?
Collaborator
There was a problem hiding this comment.
Also, maybe we could make it pub(in crate::backend) to make sure someone doesn't accidentally use it incorrectly? Not sure what kind of side effect it would have; previously, all server timings were self-contained, so an outside caller couldn't break them.
Collaborator
|
A case can be made here to fork Tokio to add a once-per-runtime-tick |
jkaczman
force-pushed
the
jk-request-clock-reads
branch
from
November 13, 2026 18:20
16690d0 to
aaa70f6
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jkaczman
force-pushed
the
jk-request-clock-reads
branch
4 times, most recently
from
November 13, 2026 18:46
cd2d929 to
7b25c8f
Compare
jkaczman
force-pushed
the
jk-request-clock-reads
branch
from
November 13, 2026 18:59
7b25c8f to
51ea109
Compare
Contributor
|
Metal bench (x86) failed. 46 of 517 measures outside bounds.
Counters per txn
Microbench: 458 of 504 measures within bounds. See verdict.json for the rest.
Microbench latency: 3 benches changed more than 3%
Hot code per txn
pooler:
sharding-w2:
Logslb, microbench, pooler, sharding-w2, sharding-w8, verdict.json Compared 35ed39a with 2c54eb8 on c7i.metal-48xl (on-demand). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we read the clock 9 times per request (there were a couple other ones that I missed in #1890 from not looking at the flamegraph).
Now we read it 3 times (+ tokio's): once at the start of the request, once for the checkout timeout in
Pool::get, and once inServer::readon ReadyForQueryStats, new request and all of our timers reuse prior ones now.
Removes ~650 instructions and ~2.4% of user cycles per transaction in
poolerbench