Repository navigation
Add refactor changes on study.ask() - #300
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #299
Description of the changes
Simplify
Study::ask()by passing aPersistedTrialdirectly toTrial::new(), replacing the tuple of metadata and attributes. Initialize fixed parameters and cached user attributes in the constructor, and restrict its visibility topub(crate)since trials are created throughStudy::ask().Also use
expect()for the storage and queue locks touched by this refactor, treating poisoning as a panic. Storage operation errors continue to propagate, with queued trials restored on failure.