Skip to content

react: use link colors for inline type annotations #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityareddy-dev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

react: use link colors for inline type annotations #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a85665d
react: use link colors for inline type annotations
adityareddy-dev Nov 5, 2026
7a89f28
react: explain inline type color override
adityareddy-dev Nov 5, 2026
4cf00b8
react: remove type link CSS e2e test
adityareddy-dev Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blue-type-links.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@doc-kit/generator-react': patch
---

Use a consistent link color for inline type annotations in light and dark themes.
7 changes: 5 additions & 2 deletions packages/react/src/html/ui/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,13 @@ main {
border-radius: calc(var(--spacing, 0.25rem) * 1);

.type-link {
/* Links keep their token color; underline marks the affordance */
color: inherit;
text-decoration: underline dotted;

span {
/* Override Shiki's inline light color and rehype-shiki's !important dark color. */
color: inherit !important;
}

&:hover {
text-decoration: underline;
}
Expand Down
Loading