Repository navigation
build: exclude development files from app releases - #3594
Merged
Merged
Conversation
List every development file the release tooling still has to remove, anchored to the app root and sorted, so the app's own .nextcloudignore covers them. composer.json, package.json and their lock files stay in the release for traceability. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
nickvergessen
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release build still has to delete these development files itself because this app's .nextcloudignore doesn't list them. nextcloud-releases/server#137 now reports that per app. This adds them, anchored to the app root and sorted like recommendations' file. composer.json, package.json and their lock files stay in the release on purpose, for traceability.
I checked it with
git ls-files -ci --exclude-from=.nextcloudignoreon master, stable35, stable34 and stable33: no development file is left at the root, and nothing else changes in what ships.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.