Repository navigation
Revert #1085: return next to its state before #1085 - #1091
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #1085, which was merged into
nextas 09840a8, at the maintainer's request. It returnsnextto its state before #1085.next(e.g. the Hold-out test: ring calibration vs ring + FitCalibration clean-up on unseen sub-runs #1074 hold-out study, Study: hold-out test of a FitCalibration clean-up after the ring calibration #1084) are untouched, because they were already onnext.next's files are identical tonextjust before Fitting UIs: texture save, multi-run save, run names, and related fixes (#1080) #1085 merged (f567c74): the diff between them is empty, and that state passed CI before. History is kept; nothing is force-pushed.What this removes again
The #1080 work and the bugs fixed alongside it:
read_run_numberreturning -1 for merged files;write_peak_parametersrecreating changed datasets;docs/ground_truths.mdentries.Those bugs are therefore back on
next. The texture Fit crash on every unsplit file in particular has been a regression since 4cab5d9.Follow-up
nextafter this revert merges.Refs #1080
🤖 Generated with Claude Code