Repository navigation
ci: remove unsupported 1ES release job outputs - #2030
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 1 commit intoNov 6, 2026
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 1 commit into
Ramses Sanchez-Hernandez (ramsessanchez) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 5, 2026 23:58
Gavin Barron (gavinbarron)
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted! Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.
NOTE: PR's will be accepted only in case of appropriate information is provided below
Summary
Remove only
PublishNpm.templateContext.outputsfrom the production pipeline. KeepBuildPackage.templateContext.outputspublishingsdk-buildand the production release job'stemplateContext.inputsconsuming it unchanged. ESRP configuration, environment, tag trigger, version equality check, and Publish-stage gating are unchanged.Update CONTRIBUTING's Production pipeline guidance: Build publishes
sdk-buildwith the packed.tgz; the release job consumes it for ESRP and cannot emit artifact outputs.release-dropis no longer produced, and remaining consumers must usesdk-build. Manual and branch runs remain build-only. No versions or tags were modified, and no release was initiated.Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
The migration merged in #2026 fails private 1ES template expansion with
/v1/Jobs/ReleaseJob.yml@1ESPipelineTemplates (Line: 93, Col: 5): Unexpected value 'A release job cannot have outputs (see stage: Publish, job: PublishNpm)'. The tarball is already published by Build and consumed by PublishNpm, so removing the unsupported release output preserves ESRP's artifact input without rebuilding or repacking.Test plan
Demonstrate the code is solid. Example: The exact commands you ran and their output.
Exact local commands and results:
python C:\Users\ramsess\.copilot\session-state\76e601f0-c989-464f-b3d0-5ac2416e54c5\files\validate-release-job.py— passed using available PyYAML. Output:PASS: YAML parsing, releaseJob output prohibition, sdk-build artifact wiring, ESRP folder, tag gate, and all remaining pipeline configuration unchanged. This session-local validation script parses the pipeline, asserts no outputs on the production releaseJob, matches Build'ssdk-buildoutput to the release input and ESRP folder, checks the pack destination and exact tag gate, and compares the entire parsed pipeline against dev commit104ad572dwith only the release output removed. The script is not added to the repository.git diff --check— passed, no output.SDK
npm run build,npm run test, andnpm run lintwere not run: this is a pipeline/docs-only fix with no SDK code or dependency changes. Private 1ES template compilation still requires Azure DevOps validation. A manual PR-branch run remains build-only, including manual runs targeting tags; do not recreate a tag or retry publication for validation.Closing issues
No linked issue.
Types of changes
Checklist