Repository navigation
ADR: code generator NeXus hints say -lhdf5 (follow-up to #2895) - #2916
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2895, which was merged before these commits were pushed to its branch.
This adds the ADR for #2895's small code generator change:
cogen.c.innow prints-DUSE_NEXUS -lhdf5instead of-DUSE_NEXUS -lNeXusin its two NeXus hints, the--verbose"Compile ..." line and the--no-runtime"Dependency: ..." line.The new file is
docs/GRAMMAR/ADR-records/ADR_20261027_NEXUS_HDF5_COGEN_HINTS.md. It records:NEXUSFLAGS;flags.nexushas to depend on the runtime version: NeXus flags/hints: follow McCode's switch from libNeXus to native HDF5 (McCode#2895) mccode-antlr#405. NeXus hint: version-neutral (libNeXus before McCode#2895, HDF5 after) mccode-antlr#406 makes its hint version-neutral in the meantime.Documentation only.
🤖 Generated with Claude Code