Repository navigation
Reserved MAV_CMD params are not declared (NaN/INT32_MAX sentinels) - #800
Merged
hamishwillee merged 4 commits intoNov 12, 2026
Merged
Conversation
Unused MAV_CMD params are now reserved by omission (mavlink/mavlink#2629). Replace the reserved="true" declaration example with MAV_CMD_DO_JUMP, add MISSION_ITEM_INT to the sentinel list, drop the uncited ArduPilot claim, and note which declared params the toolchain still treats as reserved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mark the param reserved attribute as do-not-use and the param default attribute as unused/deprecated (no generator uses it), and remove the reserved="true" default="NaN" sentinel guidance (sentinels are documented in define_xml_element#reserved). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unused params 2-4 are no longer declared, and params 5-7 use the Latitude/X, Longitude/Y, Altitude/Z labels and descriptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reserved MAV_CMD params use NaN/INT32_MAX sentinels, not 0; link to define_xml_element#reserved for the values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the devguide so that it correctly notes how to "reserve" params, and what their default values should be set to.
mavlink/mavlink#2629 removed all reserved
<param>declarations fromcommon.xml: an unused MAV_CMD param is now reserved by omission, and the generators document it as `Reserved. Default: NaN.` (params 1-4, 7) or `Reserved. Default: INT32_MAX (COMMAND_INT/MISSION_ITEM_INT) or NaN (COMMAND_LONG).` (params 5, 6).This aligns the devguide with that:
MISSION_ITEM_INTto the sentinel list, replaces the uncited ArduPilot claim with the "planning to migrate" note used in the generated docs, replaces thereserved="true" default="NaN"example with the realMAV_CMD_DO_JUMPentry, and notes which declared params the toolchain still treats as reserved (reserved="true", blank, or text starting Reserved/Empty/Unused/Not used/N/A/Spare).<param>: unused params must not be declared; `reserved` marked do-not-use; `default` marked unused/deprecated (no generator uses it); removes the old sentinel declaration guidance.MAV_CMD_NAV_PAYLOAD_PLACEupdated to match current XML.Follow-up for mavlink/mavlink:
MAV_CMD_DO_ORBITparam 4 andMAV_CMD_OBLIQUE_SURVEYparams 2, 3, 5, 6 still declaredefault="0"(and DO_ORBIT'sdefaultconflicts with its "NaN: Use vehicle default" text).Checked:
yarn docs:buildpasses;yarn linkcheckoutput unchanged from master.🤖 Generated with Claude Code