Repository navigation
Conversation
…o.http.tls.enabled Removed the four mito TLS cert/key --set flags (certificatepath, certificatepem, privatekeypath, privatekeypem) that had modern equivalents (--tls-cert, --tls-key). Added --tls-disabled flag and OAUTH_TLS_DISABLED env var as the non-mito replacement for --set mito.http.tls.enabled=false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The --set mito.http.tls.enabled=false flag is fully replaced by --tls-disabled and OAUTH_TLS_DISABLED. Removes parseMitoTLSSetArg, deprecation warnings, help text, locale entries, and tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The authorize and token request bodies used unnecessary oneOf wrappers around the schema refs. Simplify to direct $ref as CI expects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ran go mod tidy to sync go.sum with go.mod. Fixes CI build and lint failures due to missing go.sum entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mw-gregs
requested changes
Sep 18, 2026
Replaces all --set oas.* references with --set oacp.* in config parsing, deprecation warnings, help output (en/fr), locale files, tests, and documentation. The MATLAB API reference (googlesheets.oas) is unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove --set oacp.* flags, MW_* env vars, app.yaml loading, and all deprecation warning infrastructure - Remove --legacy help flag and PrintHelpLegacy - Remove --tls-disabled flag (TLS is simply off when certs not provided) - Make mwlegacy opt-in: --mwlegacy-port <port> enables the legacy listener instead of default-on with --mwlegacy-enabled=false to disable - Remove --mwlegacy-enabled flag and OAUTH_MWLEGACY_ENABLED env var - Derive MWLegacyEnabled() from MWLegacyPort being set - Rename help.go struct fields to use TLS/MWLegacy casing - Clean up locale JSON files, tests, README, UPGRADING.md, and arch spec - Delete unused testdata/app.yaml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restores the lint suppression that was present on the old printHelp function before the rewrite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Help text no longer uses message.Printer, so the gotext directive now scans only the redirect package. The catalog shrinks from 49 entries to the 3 redirect-page strings actually used at runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mw-gregs
requested changes
Sep 21, 2026
mw-gregs
left a comment
Collaborator
There was a problem hiding this comment.
Looks great and in line with the spirit of the last comments. A few new ones -- small, I think.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Spells out that the flag serves POST /oauth/v1/api on the given port, rather than the vague "Enable legacy API on this port". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Not needed for the open-source repo; upgrade guidance will be provided directly to existing users if needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mw-gregs
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all mito CLI options. For TLS disable, added a new non-mito based CLI args. For all others, non-mito equivalents already existed