Skip to content

Removed mito CLI options - #1

Closed
jhoyt15 wants to merge 20 commits into
mainfrom
jhoyt_CLI_updates
Closed

jhoyt15 wants to merge 20 commits into
mainfrom
jhoyt_CLI_updates

Conversation

@jhoyt15

@jhoyt15 jhoyt15 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Removed all mito CLI options. For TLS disable, added a new non-mito based CLI args. For all others, non-mito equivalents already existed

Jackson Hoyt and others added 13 commits August 10, 2026 08:31
…o.http.tls.enabled

Removed the four mito TLS cert/key --set flags (certificatepath, certificatepem,
privatekeypath, privatekeypem) that had modern equivalents (--tls-cert, --tls-key).
Added --tls-disabled flag and OAUTH_TLS_DISABLED env var as the non-mito replacement
for --set mito.http.tls.enabled=false.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The --set mito.http.tls.enabled=false flag is fully replaced by
--tls-disabled and OAUTH_TLS_DISABLED. Removes parseMitoTLSSetArg,
deprecation warnings, help text, locale entries, and tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The authorize and token request bodies used unnecessary oneOf wrappers
around the schema refs. Simplify to direct $ref as CI expects.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ran go mod tidy to sync go.sum with go.mod. Fixes CI build and lint
failures due to missing go.sum entries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment thread internal/app/run_test.go Resolved
Comment thread internal/locales/en-US/out.gotext.json Resolved
Comment thread internal/locales/en-US/out.gotext.json Resolved
Comment thread internal/locales/en-US/out.gotext.json Resolved
Comment thread internal/config_test.go Resolved
Comment thread internal/config_test.go Resolved
Comment thread internal/help.go Resolved
Comment thread internal/help.go Resolved
Comment thread go.mod Resolved
Jackson Hoyt and others added 4 commits September 18, 2026 14:01
Replaces all --set oas.* references with --set oacp.* in config parsing,
deprecation warnings, help output (en/fr), locale files, tests, and
documentation. The MATLAB API reference (googlesheets.oas) is unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove --set oacp.* flags, MW_* env vars, app.yaml loading, and all
  deprecation warning infrastructure
- Remove --legacy help flag and PrintHelpLegacy
- Remove --tls-disabled flag (TLS is simply off when certs not provided)
- Make mwlegacy opt-in: --mwlegacy-port <port> enables the legacy
  listener instead of default-on with --mwlegacy-enabled=false to disable
- Remove --mwlegacy-enabled flag and OAUTH_MWLEGACY_ENABLED env var
- Derive MWLegacyEnabled() from MWLegacyPort being set
- Rename help.go struct fields to use TLS/MWLegacy casing
- Clean up locale JSON files, tests, README, UPGRADING.md, and arch spec
- Delete unused testdata/app.yaml

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restores the lint suppression that was present on the old printHelp
function before the rewrite.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Help text no longer uses message.Printer, so the gotext directive now
scans only the redirect package. The catalog shrinks from 49 entries
to the 3 redirect-page strings actually used at runtime.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@mw-gregs mw-gregs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and in line with the spirit of the last comments. A few new ones -- small, I think.

Comment thread doc/UPGRADING.md Resolved
Comment thread doc/UPGRADING.md Resolved
Comment thread internal/help.go Resolved
Jackson Hoyt and others added 3 commits September 21, 2026 11:40
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Spells out that the flag serves POST /oauth/v1/api on the given port,
rather than the vague "Enable legacy API on this port".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Not needed for the open-source repo; upgrade guidance will be provided
directly to existing users if needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhoyt15 jhoyt15 closed this Sep 22, 2026
@jhoyt15
jhoyt15 deleted the jhoyt_CLI_updates branch September 22, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants