Repository navigation
feat: package generated Refinery configuration types - #7
Merged
Merged
Conversation
sam-spinner
approved these changes
Sep 24, 2026
sam-spinner
approved these changes
Sep 24, 2026
…efinery-config-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Addresses TASK-387311: Turn makenotion/refinery into refinery type source of truth
This PR makes
makenotion/refinerythe source of truth for TypeScript configuration types, enabling a future typed config generator innotion-next. It builds on the approach proposed in this closed PR.Reviewer note:
config-types/index.d.tsis generated from Refinery’s metadata and accounts for most of the diff. Focus review on the generator, tests, and package setup; the declarations can be spot-checked rather than reviewed line by line. CI verifies that the generated output is up to date.Short description of the changes
@notionhq/refinery-config-types, exporting generated configuration, sampling-rule, and sampler types.config/metadata/configMeta.yamlandrulesMeta.yaml, including field documentation and defaults.How was this tested?
npm testpasses, including generated-file freshness checks, valid/invalid TypeScript configuration examples, and seven generator regression tests.There are no runtime or deployment configuration changes. A follow-up PR in
notion-nextwill officially add the dependency and typed configuration generator.