Skip to content

ci(helm): install the chart from an image built in the workflow - #504

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
ajaysundark:helm-ci-build-image
Nov 13, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
ajaysundark:helm-ci-build-image

Conversation

@ajaysundark

Copy link
Copy Markdown
Contributor

Description

Install the chart in the Helm workflow from an image built in the workflow instead of pulling registry.k8s.io/...:<appVersion>.

A release-cut PR bumps appVersion before the tag exists, so ct install sits in ImagePullBackOff and the Helm check can never pass on the PR that cuts the release (#501 is failing on this). Since #453 ties appVersion to the VERSION file, every future cut hits it.

Changes in .github/workflows/helm.yaml: make docker-build from the checkout, kind load into the nrr-test cluster, and ct install --helm-extra-set-args "--set image.repository=node-readiness-controller --set image.tag=ci".

Related Issue

Unblocks #501.

Type of Change

/kind failing-test

Testing

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

NONE

Generative AI Usage Disclosure

  • No AI tools were used
  • AI tools were used (complete below)

How they were used:
An AI coding agent drafted the workflow change and ran the kind reproduction above. I reviewed the change.

ct install pulled registry.k8s.io/...:<appVersion>, so a release-cut PR
that bumps appVersion before the tag exists could not pass the Helm
check. Build the controller image from the checkout, load it into kind,
and install the chart with image.repository/tag pointed at it.

Change-Id: I4aa5a74770a5dc26cee208a141383c9d3eae4c84
Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
@kubernetes-prow kubernetes-prow Bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 12, 2026
@netlify

netlify Bot commented Nov 12, 2026

Copy link
Copy Markdown

👷 Deploy request for node-readiness-controller pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9aed4e8

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2026
@ajaysundark

Copy link
Copy Markdown
Contributor Author

/cc @Karthik-K-N

@Karthik-K-N Karthik-K-N left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit fae43c2 into kubernetes-sigs:main Nov 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants