Repository navigation
ci(helm): install the chart from an image built in the workflow - #504
Merged
kubernetes-prow[bot] merged 1 commit intoNov 13, 2026
Merged
Conversation
ct install pulled registry.k8s.io/...:<appVersion>, so a release-cut PR that bumps appVersion before the tag exists could not pass the Helm check. Build the controller image from the checkout, load it into kind, and install the chart with image.repository/tag pointed at it. Change-Id: I4aa5a74770a5dc26cee208a141383c9d3eae4c84 Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
👷 Deploy request for node-readiness-controller pending review.Visit the deploys page to approve it
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/cc @Karthik-K-N |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Install the chart in the Helm workflow from an image built in the workflow instead of pulling
registry.k8s.io/...:<appVersion>.A release-cut PR bumps
appVersionbefore the tag exists, soct installsits inImagePullBackOffand the Helm check can never pass on the PR that cuts the release (#501 is failing on this). Since #453 tiesappVersionto theVERSIONfile, every future cut hits it.Changes in
.github/workflows/helm.yaml:make docker-buildfrom the checkout,kind loadinto thenrr-testcluster, andct install --helm-extra-set-args "--set image.repository=node-readiness-controller --set image.tag=ci".Related Issue
Unblocks #501.
Type of Change
/kind failing-test
Testing
make kind-multi-node, chart edited toappVersion: v0.6.0, built and loaded the image, ranct installwith the flags above:All charts installed successfully.Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Generative AI Usage Disclosure
How they were used:
An AI coding agent drafted the workflow change and ran the kind reproduction above. I reviewed the change.