Skip to content

fix(chart): set unhealthyPodEvictionPolicy on the PDB - #487

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
DsThakurRawat:fix/pdb-unhealthy-eviction
Nov 9, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
DsThakurRawat:fix/pdb-unhealthy-eviction

Conversation

@DsThakurRawat

Copy link
Copy Markdown
Contributor

Description

Sets unhealthyPodEvictionPolicy (default AlwaysAllow) on the chart's PodDisruptionBudget so unhealthy pods do not block voluntary evictions indefinitely. Rendered only on clusters >= 1.27 where the field is supported, and omitted when empty. Found via kube-linter on the fully-rendered chart.

Related Issue

None

Type of Change

/kind feature

Testing

  • helm unittest --strict: 43/43 pass (5 runs), including 2 new PDB cases
  • helm lint: clean
  • helm template on kube 1.25/1.26 omits the field, on 1.29 renders it
  • kube-linter finding that motivated this no longer fires; hack/verify-chart-drift.sh clean

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

NONE

Generative AI Usage Disclosure

  • No AI tools were used
  • AI tools were used (complete below)

How they were used:
AI assistance drafted the template stanza, values/docs rows, and unittest cases. Every line was verified by local runs before pushing: helm unittest (5x), lint, multi-version template renders, kube-linter, chart drift check.

@kubernetes-prow kubernetes-prow Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2026
@netlify

netlify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit b9e97ab
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6af23c3858f01ca28bf17369

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @DsThakurRawat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2026
@DsThakurRawat

Copy link
Copy Markdown
Contributor Author

This looks good to me

@DsThakurRawat
DsThakurRawat force-pushed the fix/pdb-unhealthy-eviction branch from d1b7ee0 to fbecbe0 Compare October 17, 2026 16:05
@ajaysundark

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2026
@ajaysundark

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @DsThakurRawat. Could you resolve the merge conflicts?

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2026
Render unhealthyPodEvictionPolicy (default AlwaysAllow) into the
PodDisruptionBudget so unhealthy pods do not block voluntary evictions
indefinitely. Gated on clusters >= 1.27 where the field is supported
and omitted when empty. Covered by helm-unittest.

Signed-off-by: Divyansh Rawat <divyanshrawatofficial@gmail.com>
@DsThakurRawat
DsThakurRawat force-pushed the fix/pdb-unhealthy-eviction branch from fbecbe0 to b9e97ab Compare November 9, 2026 21:33
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2026
@ajaysundark

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, DsThakurRawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 49611a2 into kubernetes-sigs:main Nov 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants