Repository navigation
Stabilize the paused-tool durability test on CI - #1183
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
For context, the CI failure that prompted this PR was on the Desktop 0.8.0 release candidate (#1182). This PR increased the paused-tool test’s watchdog from two to ten seconds. The fix could have landed directly on |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paused-tool durability fixture waits for both the pending gate and its sibling’s committed result. Its two-second test watchdog expired on the Windows runner. Increase the fixture watchdog to ten seconds and give each timeout a specific failure message. The fixture still requires the same durable result, pause, and recovery assertions.
The original test reproduced the timeout locally with a temporary 2.25-second gate delay. The corrected test passed with the same delay. The full
grida-agent-mastersuite passed with normal timing.Windows CI failure