Repository navigation
Clamp CacheTopology::l3_count_ to [1, 256]. - #1856
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1014423300
branch
from
November 5, 2026 17:50
8b282c8 to
dfc18ad
Compare
copybara-service
Bot
changed the title
CacheTopology::l3_cache_index_ stores each CPU's L3 shard index in a uint8_t, wrapping indices modulo 256 when more than 256 L3 domains are present in sysfs. Clamp l3_count_ to [1, 256] after scanning CPUs so GetL3FromCpuId(cpu) < l3_count() continues to hold without growing ShardedTransferCacheManager beyond 256 shards. PiperOrigin-RevId: 1014423300
copybara-service
Bot
force-pushed
the
test_1014423300
branch
from
November 5, 2026 20:57
dfc18ad to
1654d3a
Compare
copybara-service
Bot
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp CacheTopology::l3_count_ to [1, 256].
CacheTopology::l3_cache_index_ stores each CPU's L3 shard index in a
uint8_t, wrapping indices modulo 256 when more than 256 L3 domains are
present in sysfs. Clamp l3_count_ to [1, 256] after scanning CPUs so
GetL3FromCpuId(cpu) < l3_count() continues to hold without growing
ShardedTransferCacheManager beyond 256 shards.