Repository navigation
[1/2] feat(lsp): add version-aware PHPantom runtime - #435
Open
glassmonkey wants to merge 13 commits into
Open
glassmonkey wants to merge 13 commits into
glassmonkey wants to merge 13 commits into
Conversation
glassmonkey
marked this pull request as ready for review
November 1, 2026 15:29
glassmonkey
force-pushed
the
gla-115-phpantom-runtime
branch
from
November 3, 2026 13:52
dd9f969 to
895c3e9
Compare
Share import kind, namespace prefix and replacement range across candidate generation. Compare complete editing payloads and accepted documents through public native/WASI requests, including alias collisions and PHP bindings. Publish headless didChange parsing before subsequent requests to prevent the observed rename race.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1 of 2: PHPantom build and runtime foundation
Base:
master(merged PHP web-build PR #437). Merge this PR first, then release #434.This PR adds the build/runtime foundation without enabling autocomplete in the editor. The editor UI and its URL-controlled default-on behavior are introduced by #434.
Changes
src/lsp/phpantomand Docker/build/patch/native/WASI validation tools insrc/lsp/wasm, following the existing PHP runtime/build module split.install-phpantom-runtime; module scripts do not write to assets/public.PHP_VERSIONS; explicit version overrides remain available.Reproducible inputs
49b9a7513ed19cbbfb79d5d08a3f3693ffb2b668.f5861b581a5503c7bf033df82390d08fbc9a971fa769afa90a310d0c623eb59d.4996a41403b2c570ba3e6a5a67c86bbe2833129c95bca62f19c5e39581a4b31d.2049ca3cfa1feabf52db074108fe776a5713cf02; archive SHA-2563ef62542d2f77ad30c7dab7dfa726e57e86dd5e3403780294119cf4f5ca6dcb7.rust:1.99.0-bookworm@sha256:114c7a4425406451c2866b6aafe69fe29b1b298832db1277d411ac73c82d04d6.Validation and limits
Runtime correction source:
d1b805e6eeeaaca8f5c8153997b836c9e99aa455. Current PR head:40b65b796d392050bb7d551bbaac8f3f65cedf84; the later commit only removes the two master-only PR base filters so stacked PRs are checked.complete=true, raw 6/7, exit 101, the sole documented same-name user PHPDoc marker failure,knownLimitMatched=true,unexpectedFailures=0. Guards 2/2 and scanner 1/1 passed separately. It is not a raw 7/7 pass. Replaying the actual Docker log with unwrap/missing-finish/extra-FAIL/truncation mutations was rejected.7c874fef41f7082b20f437469945904c3d2d542861cce36dffccef0b8751430a; installed bytes/version/provenance match each attempt. Original candidate proof bytes and mtimes are unchanged across reuses. Failed build leaves the existing destination unchanged.git diff --checkpassed. Source/patch/stubs pins and existing execution/assets/browser code remain unchanged. No UI/client/editor changes and no 12-target rebuild.Release handoff
master.master; rebase if required by the chosen merge method or intervening changes.No merge or deployment has been performed by this PR preparation.
Final review status
Accepted for review on head
40b65b796d392050bb7d551bbaac8f3f65cedf84. No merge or deployment performed. Release order remains #435, then #434 after retargeting and checking its resulting base/head.