Repository navigation
Keep subseconds when formatting durations with %OS - #5019
Open
chinmayajha wants to merge 1 commit into
Open
chinmayajha wants to merge 1 commit into
chinmayajha wants to merge 1 commit into
Conversation
chinmayajha
force-pushed
the
duration-os-subseconds
branch
from
November 8, 2026 08:26
a84fc85 to
4acf78d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%OSdrops sub-seconds when formatting a duration:fmt::format("{:%OS}", std::chrono::milliseconds(1234))gives01, while{:%S}gives01.234. In the classic locale the alternative representation is the same as the standard one, and libc++'sstd::formatprints01.234for both.The time_point formatter already handles this:
tm_writer::on_seconduses the standard path when the locale is classic. This uses the same condition induration_formatter::on_second. WithLand a non-classic locale it still goes through the locale's%OSwithout sub-seconds, same as for time points.The new test fails before the change and the full test suite passes. It is independent of #5018.