Repository navigation
fix(cli): keep the selected instance in the commands that hints suggest - #74
Merged
Merged
Conversation
Commands printed by errors, env and doctor now carry --profile, --container and an explicit --endpoint, so pasting one acts on the same instance. After a failed pull, the suggested start also keeps the --port, --image, --persist, --services and --namespace you typed. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
 [Medium impact] The PR appears safe to merge; both numbered findings are fixed and no new actionable issues were found.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ry shell A profile can set output: json, so the hint now adds -o text after --profile; pasted without it, the shell received JSON. Selector values are quoted for the shell the hint is for, since PowerShell and fish do not read the POSIX form. Addresses the review of #74. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
Signed-off-by: Hector Ventura <hectorvent@gmail.com> # Conflicts: # plugin.json # skills/floci/SKILL.md # src/main/java/io/floci/cli/commands/StartCommand.java
This branch changes the skill, and 1.0.2 shipped with #73. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
The hint is a comment in the output people feed to eval, so a line break in a selector value ended the comment and ran the rest. Such a value now prints as a placeholder. Fish and PowerShell always get quotes, because the plain-word rule is POSIX and @team is a splat in PowerShell. Addresses the review of #74. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
hectorvent
added a commit
that referenced
this pull request
Nov 4, 2026
This branch changes the skill, and 1.0.3 shipped with #74. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commands suggested by errors,
envanddoctordropped the selected instance, so pasting one acted on the default instance instead.--profile,--containerand an explicit--endpoint.start --pull neveralso keeps the--port,--image,--persist,--servicesand--namespaceyou typed.envload hints are quoted for the shell they are for, and add-o textafter a profile, which may setoutput: json.doctorfix lines in-o jsongain the selector only when an instance is selected.Type of change
fix:)feat:)feat!:orfix!:)Product trees affected
commands/gcp/)commands/az/)Checklist
mvn testpasses locallyREADME.mdupdated (if a command or flag changed)mvn package -Pnative), required if Jackson serialization or dependencies changedfeat/fix/perfsubject becomes the release note, soCHANGELOG.mdneeds no hand editTests
InstanceHintsTestcovers all four trees;StartPreflightTestnow expects the selector. 761 tests, 0 failures. Ran the failed-pull anddoctorhints from a fat JAR with this change merged alongside the other open work, not on this branch alone. Native build and smoke pass on linux/amd64 and darwin/arm64 in that same merged build. OCI is covered too: the template has no box for it.