Repository navigation
ci: expand native smoke coverage for CLI commands and output - #72
Merged
Merged
Conversation
Run completion, Compose validation with YAML anchors and merge keys, profile editing, JSON, YAML and plain output, and the snapshot and reset input guards through the native binary. None of it needs an emulator or a Docker daemon. Profile editing is skipped on Windows: it has not been proven there, and the script runs on Windows only while a release is being cut. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
 [Medium impact] The PR appears safe to merge, with no outstanding findings.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Piped output is already plain and version prints no glyphs, so the ASCII check could not fail. Keep the parse check; ErgonomicsTest covers the behaviour. Addresses the review of #72. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset,config validate,config profile edit,--json,--no-emoji,completionand-o yamlwere not run on a native binary anywhere in CI, and the JVM tests cannot catch a native-image gap.smoke.shnow runs them, with no emulator or Docker daemon.--no-emojiis only checked to parse: piped output is already plain, so its effect stays withErgonomicsTest.::error::so the cause shows in the CI log.Type of change
fix:)feat:)feat!:orfix!:)Product trees affected
commands/gcp/)commands/az/)Checklist
mvn testpasses locallyREADME.mdupdated (if a command or flag changed)mvn package -Pnative), required if Jackson serialization or dependencies changedfeat/fix/perfsubject becomes the release note, soCHANGELOG.mdneeds no hand editTests
No Java changed, so
mvn testis not relevant here. Ran the script against native binaries on linux/amd64 and darwin/arm64, each also with nodockeronPATH. Not run on Windows or darwin/amd64: those only run it from a release tag, so the first Windows run of the other new checks will be during a release.