Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -1852,6 +1852,9 @@ def apply(
lvs_to_delete = [
ob for ob in objects_to_delete if isinstance(ob, LabelView)
]
saved_datasets_to_delete = [
ob for ob in objects_to_delete if isinstance(ob, SavedDataset)
]

for data_source in data_sources_to_delete:
self.registry.delete_data_source(
Expand Down Expand Up @@ -1885,6 +1888,10 @@ def apply(
self.registry.delete_validation_reference(
validation_references.name, project=self.project, commit=False
)
for saved_dataset in saved_datasets_to_delete:
self.registry.delete_saved_dataset(
saved_dataset.name, project=self.project, commit=False
)
for permission in permissions_to_delete:
self.registry.delete_permission(
permission.name, project=self.project, commit=False
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@
from feast.feature_store import FeatureStore
from feast.feature_view import DUMMY_ENTITY_ID, DUMMY_ENTITY_NAME, FeatureView
from feast.field import Field
from feast.infra.offline_stores.file_source import FileSource
from feast.infra.offline_stores.file_source import FileSource, SavedDatasetFileStorage
from feast.infra.online_stores.dynamodb import DynamoDBOnlineStore
from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
from feast.on_demand_feature_view import OnDemandFeatureView
from feast.permissions.action import AuthzedAction
from feast.permissions.permission import Permission
from feast.permissions.policy import RoleBasedPolicy
from feast.repo_config import RegistryConfig, RepoConfig
from feast.saved_dataset import SavedDataset
from feast.stream_feature_view import stream_feature_view
from feast.transformation.pandas_transformation import PandasTransformation
from feast.types import Array, Bytes, Float32, Int64, String, ValueType, from_value_type
Expand Down Expand Up @@ -443,6 +444,34 @@ def test_apply_permissions(test_feature_store):
test_feature_store.teardown()


@pytest.mark.parametrize(
"test_feature_store",
[lazy_fixture("feature_store_with_local_registry")],
)
def test_apply_delete_saved_dataset(test_feature_store):
"""Test that a saved dataset can be deleted using objects_to_delete with partial=False."""
assert isinstance(test_feature_store, FeatureStore)

saved_dataset = SavedDataset(
name="my_saved_dataset",
features=["driver_fv:conv_rate"],
join_keys=["driver_id"],
storage=SavedDatasetFileStorage(path="my_saved_dataset.parquet"),
)
test_feature_store.registry.apply_saved_dataset(
saved_dataset, test_feature_store.project, commit=True
)
assert len(test_feature_store.list_saved_datasets()) == 1

test_feature_store.apply(
objects=[], objects_to_delete=[saved_dataset], partial=False
)

assert test_feature_store.list_saved_datasets() == []

test_feature_store.teardown()


def _apply_feature_view_to_delete(test_feature_store, file_source):
"""Register an entity and a feature view, and return the feature view."""
entity = Entity(
Expand Down