Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
The change has an active documentation issue: the packages.yaml example in docs/spack-environment.md is out of sync with the actual spack-environment/packages.yaml, making the updated guidance misleading until corrected.
1 open issue
What changed in this PR
Updates the Spack environment configuration to prefer/build key packages with C++23, aligning the software stack with upcoming upstream requirements.
Changes:
- Bump
cxxstdconstraints to 23 for multiple packages inspack-environment/packages.yaml, while retaining documented exceptions where C++23 is not yet supported. - Update the Spack environment documentation example to reflect the newer ROOT version and
cxxstd=23usage.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Raises per-package Spack cxxstd requirements to 23 for several core dependencies and documents exceptions that remain on C++20. |
| docs/spack-environment.md | Updates the documentation’s example packages.yaml snippet to reflect the current ROOT version and cxxstd=23 settings. |
Review effort: Balanced
wdconinc
enabled auto-merge (squash)
November 11, 2026 01:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR bumps the C++ standard where possible to 23. There are a few interlinked dependency trees that change in lock step due to their inclusion of headers. Upcoming changes that we want to prepare for:
Motivation is also the availability of some generic algorithms on containers that would be useful to take advantage of. In particular, iteration over two coordinated containers (e.g. hits and links) using
zipbecomes available for use in EICrecon.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
AI propagated the changes.