Repository navigation
Survey review: add "All answers" per-question page - #241
Open
theschweitz wants to merge 3 commits into
Open
theschweitz wants to merge 3 commits into
theschweitz wants to merge 3 commits into
Conversation
Adds a page that shows everyone's answer to one survey question, opened from a new "All answers" link beside each question on the response page. - New page /survey-review/[viewId]/question?column=… with a breakdown for ratings and choices (click a bar to filter), role filter, search for written answers, a question picker, and links back to each response. - New GET /api/survey/review/[viewId]/question endpoint (same BUILDER_REVIEW_PASSWORD gate). It only returns respondents who were shown the question, and only form questions. - Moves the survey config (view allowlist, role -> question groups) to services/survey-review.ts so both endpoints share it. Keeps the view id and the MC / CLS Organizer roles from main. - Moves the shared UI (answer rendering, cards, password gate) to components/domain/survey-review so both pages share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HWm3DuqAd8a89WzuKgsMBk
👷 Deploy request for devcon-app pending review.Visit the deploys page to approve it
|
👷 Deploy request for devcon-social pending review.Visit the deploys page to approve it
|
👷 Deploy request for devconnect-pwa pending review.Visit the deploys page to approve it
|
👷 Deploy request for devconnect-monorepo pending review.Visit the deploys page to approve it
|
👷 Deploy request for devcon-monorepo pending review.Visit the deploys page to approve it
|
👷 Deploy request for devcon-archive pending review.Visit the deploys page to approve it
|
👷 Deploy request for devcon8-app pending review.Visit the deploys page to approve it
|
- Response page gets a side panel listing every response: role filter chips, a word search across all answers, and an "only with written comments" toggle. Prev/Next and the arrow keys follow the filtered list. Filters are kept for the browser tab, so they survive a trip to a question page. - New GET /api/survey/review/[viewId] endpoint for that list (same BUILDER_REVIEW_PASSWORD gate). It returns a summary per response: role, average rating, a snippet, note flag, and the text of the answers that respondent was shown, for the search. - Survey pages follow the viewer's light/dark device setting. Colors are --sr-* CSS variables scoped to the survey pages (.sr-theme), so the rest of the site is unaffected. - NOTES_COLUMN and roleLabel are shared instead of duplicated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HWm3DuqAd8a89WzuKgsMBk
Adds a Sort menu to the response list: Response # (default), lowest rating first, or highest rating first. Responses without any rating go last. Prev/Next and the arrow keys follow the sorted order, and the choice is kept for the browser tab with the other filters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HWm3DuqAd8a89WzuKgsMBk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Survey review: "All answers", side panel with search, dark mode
Follow-up to 76b3696 (survey review page for the Devcon 8 Feedback Survey).
What it adds
Side panel on the response page (
/survey-review/<viewId>/<id>)"All answers" per question
/survey-review/<viewId>/question?column=…, showing everyone's answer to that question.Dark mode
--sr-*CSS variables scoped to the survey pages (.sr-theme), so the rest of devcon.org is unaffected.Changes
GET /api/survey/review/[viewId]: the response list for the side panel (summary per response, plus the text of answers that respondent was shown, for the search).GET /api/survey/review/[viewId]/question?column=…: everyone's answer to one question. Only respondents who were shown it (role rules apply) and only form columns.BUILDER_REVIEW_PASSWORDlike the existing endpoint.services/survey-review.ts, shared by all three endpoints. The view idvwok5lvkv9uhyr6sand theMC/CLS Organizerroles from main are kept as-is.components/domain/survey-review; the side panel iscomponents/domain/survey-review/ResponseList.tsx.How to test
pnpm dev, open/en/survey-review/vwok5lvkv9uhyr6s/<any id>and unlock with the builder review password.tsc --noEmitandnpx eslinton the changed files indevcon/(not run in the authoring environment, as dependencies weren't installed there; the pages were exercised in a browser harness with stubbed NocoDB data).🤖 Generated with Claude Code
https://claude.ai/code/session_01HWm3DuqAd8a89WzuKgsMBk