Repository navigation
refactor(conduit): stop naming ProxyInitCode's store address at - #139
Merged
Merged
Conversation
solc 0.8.36 warns that `at` will become a keyword, and the file ships in @crossecute/protocol. Every src artifact's bytecode is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames
ProxyInitCode'satidentifiers, the return value ofstore()and the parameter ofload(address), toinitCodeStore.Conduits.deployalready uses that name for the same address.Why
solc 0.8.36 warns
"at" will be promoted to keyword in the futureon lines 26 and 42.ProxyInitCode.solships in@crossecute/protocol, so the warning shows up in every project that imports the package with a current compiler. The repo itself builds with 0.8.28, which doesn't warn.Checked
src/is identical before and after.--use 0.8.36, the published 0.1.0 file warns twice and this version doesn't warn.forge fmt --check,forge lint -D notes, andforge lint -D notesunderFOUNDRY_PROFILE=lint-srcare clean on the file.forge test: 1034 passed, 3 skipped.Not in this PR
at(script/deploy/ProxyDeploy.sol,test/Proxy.t.sol,test/Transport.t.soland others). They don't ship in the package and compile under the pinned 0.8.28.EnumerableSet.at(i)calls, which are OpenZeppelin's API.