Repository navigation
AIENG-379: send raw <testsuite time> as junitSuiteTime - #1422
Merged
Merged
Conversation
Lets the server compute a wall-clock session span instead of summing case durations. Sent from the raw XML attribute, not junitparser's suite.time, which coerces an absent attribute to 0.0.
ono-max
approved these changes
Nov 10, 2026
| 'stdout': '', | ||
| 'stderr': '', | ||
| 'junitSuiteTimestamp': str(timestamp2), | ||
| 'junitSuiteTime': '12.345', |
Contributor
There was a problem hiding this comment.
Can we add junitSuiteTime fields to the following JSON schema?
smart-tests-cli/launchable/test_runners/raw.py
Lines 61 to 168 in 2c1eba6
Contributor
Author
There was a problem hiding this comment.
Added junitSuiteTime to the raw record-test JSON schema and wired parse_json to forward it (with a test case).
Document it in the raw record-test JSON schema and wire parse_json to forward it, so raw-JSON users can supply the suite wall time too.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Companion to mothership PR.
test_sessions.durationsums case durations, which over-reports when a suite runs its cases in parallel. The server can compute a true wall-clock span if it knows each suite's<testsuite time>— but the CLI was discarding that attribute.What
Send the raw
<testsuite time>asjunitSuiteTimealongside the existingjunitSuiteTimestamp, on the generic JUnit record path (maven/gradle/ant/go-test/etc.).suite.time, which coerces an absent attribute to0.0— that would make the server read a zero-length suite instead of falling back to the sum of case durations.junitSuiteTimefrom those is a follow-up.Tests
CaseEvent.createcases for the field (present / absent).test_scan_test_compile_lstmaven failure is unrelated).🤖 Generated with Claude Code